Re: [Yaffs] Eh.... Patch enclosed...

On Wed, Jul 27, 2005 at 08:28:02AM +1200, Charles Manning wrote:
> Well normally yes.... This time I checked it in blind because I was in the
> middle of something else and I could not compile the structure I had.
>
> Thanx for pointing it out.

Charles,

what you did with Sergey's patch before applying? Either I'm using different
CVS or something got screwed.

Btw, kernel people tend to refuse patches without much reading when they
do not meet Documentation/CodingStyle. Interested in patch?

    ladis

Index: yaffs_fs.c
===================================================================
RCS file: /home/aleph1/cvs/yaffs2/yaffs_fs.c,v
retrieving revision 1.11
diff -u -r1.11 yaffs_fs.c
--- yaffs_fs.c    26 Jul 2005 23:04:34 -0000    1.11
+++ yaffs_fs.c    27 Jul 2005 06:40:25 -0000
@@ -179,65 +179,57 @@

-
 static struct address_space_operations yaffs_file_address_operations = {
-    .readpage=        yaffs_readpage,
-    .writepage=        yaffs_writepage,
-    .prepare_write=    yaffs_prepare_write,
-    .commit_write=    yaffs_commit_write
+    .readpage    = yaffs_readpage,
+    .writepage    = yaffs_writepage,
+    .prepare_write    = yaffs_prepare_write,
+    .commit_write    = yaffs_commit_write,
 };

-
 static struct file_operations yaffs_file_operations = {
-
-    .read=        generic_file_read,
-    .write=        generic_file_write,
-
-    .mmap=        generic_file_mmap,
-    .flush=        yaffs_file_flush,
-    .fsync=        yaffs_sync_object,
+    .read        = generic_file_read,
+    .write        = generic_file_write,
+    .mmap        = generic_file_mmap,
+    .flush        = yaffs_file_flush,
+    .fsync        = yaffs_sync_object,
 };

-
 static struct inode_operations yaffs_file_inode_operations = {
-    .setattr=    yaffs_setattr,
+    .setattr    = yaffs_setattr,
 };

-
-struct inode_operations yaffs_symlink_inode_operations =
-{    
-    .readlink=    yaffs_readlink,
-    .follow_link=    yaffs_follow_link,
-    .setattr=    yaffs_setattr
+struct inode_operations yaffs_symlink_inode_operations = {    
+    .readlink    = yaffs_readlink,
+    .follow_link    = yaffs_follow_link,
+    .setattr    = yaffs_setattr,
 };

 static struct inode_operations yaffs_dir_inode_operations = {
-    .create=        yaffs_create,
-    .lookup=        yaffs_lookup,
-    .link=        yaffs_link,
-    .unlink=        yaffs_unlink,    
-    .symlink=    yaffs_symlink,
-    .mkdir=        yaffs_mkdir,
-    .rmdir=        yaffs_unlink,
-    .mknod=        yaffs_mknod,
-    .rename=        yaffs_rename,
-    .setattr=    yaffs_setattr,
+    .create        = yaffs_create,
+    .lookup        = yaffs_lookup,
+    .link        = yaffs_link,
+    .unlink        = yaffs_unlink,    
+    .symlink    = yaffs_symlink,
+    .mkdir        = yaffs_mkdir,
+    .rmdir        = yaffs_unlink,
+    .mknod        = yaffs_mknod,
+    .rename        = yaffs_rename,
+    .setattr    = yaffs_setattr,
 };

 static struct file_operations yaffs_dir_operations = {
-    .read=        generic_read_dir,
-    .readdir=    yaffs_readdir,
-    .fsync=        yaffs_sync_object,
+    .read        = generic_read_dir,
+    .readdir    = yaffs_readdir,
+    .fsync        = yaffs_sync_object,
 };

-
 static struct super_operations yaffs_super_ops = {
-    .statfs=            yaffs_statfs,
-    .read_inode=        yaffs_read_inode,
-    .put_inode=        yaffs_put_inode,
-    .put_super=        yaffs_put_super,
-    .delete_inode=        yaffs_delete_inode,
-    .clear_inode=        yaffs_clear_inode,
+    .statfs        = yaffs_statfs,
+    .read_inode    = yaffs_read_inode,
+    .put_inode    = yaffs_put_inode,
+    .put_super    = yaffs_put_super,
+    .delete_inode    = yaffs_delete_inode,
+    .clear_inode    = yaffs_clear_inode,
 };