[Yaffs] delete inode on 2.6.14

[trimarchi at gandalf.sssup.it]

Hi,
I know this is not a patch but a change in the old yaffs project for 
the peaple
that want to use yaffs on new kernel. The test on inode->i_data.nrpages 
is only
done for decrease function call.

Regards
Michael

Quoting Todd Poynor <tpoynor at mvista.com>:

> Michael Trimarchi wrote:
>> I think the yaffs_delete_inode  on yaffs must be correct on new kernel.
> ...
>> The new one:
>
> It's helpful to use the patch format for discussing code changes.
> ...
>>        if (inode->i_data.nrpages)
>>                truncate_inode_pages(&inode->i_data, 0);
> ...
>> Is it correct?
>
> yaffs2 CVS module has similar code, should be added to the deprecated 
> yaffs module as well if maintainers agree:
>
> #if (LINUX_VERSION_CODE > KERNEL_VERSION(2,6,13))
>         truncate_inode_pages (&inode->i_data, 0);
> #endif
>
> The check for inode->i_data.nrpages is not necessary, the callee 
> already does this, and it may not be safe if the implementation 
> changes in the future.  Thanks,
>
> -- 
> Todd
>



----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.