[Yaffs] Using the CVS version

[Karl Olsen]

On Friday, May 13, 2005 3:43 AM [GMT+1=CET],
Charles Manning <manningc2@actrix.gen.nz> wrote:

> On Friday 13 May 2005 03:55, Karl Olsen wrote:
>
>> I am using yaffs on Linux 2.6.11.5, based on the Frank Rowand
>> patches from 2004-12-16.  I was having some problems, so I wanted to
>> try the current version, fetched as "Download tarball" from
>> http://www.aleph1.co.uk/cgi-bin/viewcvs.cgi/yaffs/ .  According to
>> the CVS entries, some things have been fixed since last December.
>>
>> But after trying the patch-ker.sh (and adding the real yaffs files to
>> fs/yaffs and the missing "obj-$(CONFIG_YAFFS_FS) += yaffs/" to
>> fs/Makefile), it didn't compile at all.  It looks like none of the
>> necessary fixes that Frank Rowand made have been applied to CVS.  Is
>> there an up-to-date version somewhere, or what am I doing wrong?
>
> Some of Frank's patches were applied to what was in CVS, but not all.
> Some were pretty much the same thing done a different way.

The yaffs.tar.gz I get with "Download tarball" contains a 7 month old
yaffs_mtdif.c.  The first line after the initial comment and the version
string is a #ifdef CONFIG_YAFFS_MTD_ENABLED.  So the rest of the file is
never compiled (unless CONFIG_YAFFS_MTD_ENABLED is defined in the gcc
command line).  And I got link errors because the functions in yaffs_mtdif.c
therefore weren't compiled.

Frank Rowand fixed this in by adding a #include <linux/config.h> in his
patch 2 of 7.  So this necessary fix isn't in the "Download tarball" or the
ViewCVS browser.  And when looking at the revision history for this and the
other files, I see a few later changes, but none related to the Frank Rowand
fixes.  The only sign of Frank Rowand is some "CVS Tags: pre_FrankR_changes,
HEAD" lines.  Are we looking at the same CVS?


Kind regards,
Karl Olsen