[Yaffs] mkyaffs and mkyaffsimage fixes for Linux 2.6

Fri, 21 Jan 2005 15:49:33 -0800

This is a multi-part message in MIME format.
--------------030805000800070709080609
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hopefully these fixes can be useful.

The subject line is a slight misnomer.  I'm actually building mkyaffsimage
on a Redhat 9.0 system (thus Linux 2.4.x) to run on Redhat 9.0.  I'm
building mkyaffs on Redhat 9.0 to run on Linux 2.6.10.  We will be
building on all the host systems that MontaVista supports, so I will
send additional fixes if we encounter issues on the other hosts.

If putting all the patches in one tar is inconvenient I can break them
out to one patch per email -- just let me know.

Feedback, comments, questions are all welcome.

Thanks!

-Frank
-- 
Frank Rowand <frank_rowand@mvista.com>
MontaVista Software, Inc

--------------030805000800070709080609
Content-Type: text/plain;
 name="info_userland_patches_02"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="info_userland_patches_02"

This is a list of the patches that I used to get the YAFFS userland
programs (host: mkyaffsimage, target: mkyaffs) working for Linux 2.6.10.

These changes have not checked for compatibility with Linux 2.4, but I tried
to be compatible.

Some of these fixes have been sent to this email list before, but I am
including them in this set so that I have everything I've done grouped
together in an easily found set.

yaffs_userland_01_base.patch

   The userland related files, as of Oct 27, 2004, from 
      http://www.aleph1.co.uk/cgi-bin/viewcvs.cgi/yaffs/
      "Download tarball" link

   I won't send this patch to the email list, since the files can be
   retrieved from the web sit.

   The files are:
      devextras.h
      nand_ecc.c
      yaffs_guts.h
      yportenv.h
      utils/Makefile
      utils/mkyaffs.c
      utils/mkyaffsimage.c

yaffs_userland_02_fixup_rh9.patch

   Changes needed to allow compilation of host program on Redhat 9.0.
      - /usr/include/bits/stat.h defines st_atime, st_mtime, st_ctime, thus
        these strings can not be used as field names in a yaffs data
        structure.
      - This possible fix has been discussed on the email list, but no final
        resolution exists yet.

yaffs_userland_03_mkyaffs_oobinfo.patch

   Changes needed to allow compilation of target program.
      - Declarations needed for mtd ioctls moved from the Linux 2.4 location of
        /usr/include/linux/mtd/mtd.h to the kernel header file mtd/mtd-user.h
      - Fix #include in util/mkyaffs.c.
      - Add eccbytes field to initialization of yaffs_oobinfo if Linux 2.6.
      - It is really bad to include kernel header files into userland
        programs, but I included <linux/version.h> so that Linux 2.4 vs
	Linux 2.6 could be checked.

yaffs_userland_04_fix_warnings.patch

   Make host and target program compile warnings go away....  I like my newly
   introduced errors to be more obvious.

yaffs_userland_05_64bit.patch

   struct yaffs_ObjectHeader describes an object that resides in the YAFFS
   filesystem, in the flash.  The size of the structure and offsets within
   the structure must be the same, whether on a 32 bit system or a 64 bit
   system.
      - Fix the data types used in the structure.
      - Not tested on a 64 bit system.

yaffs_userland_06_mkyaffs_damaged_count.patch

   mkyaffs writes a YAFFS filesystem image into flash, skipping damaged
   blocks in the flash.  mkyaffs checks to make sure that the image is
   not larger than the flash before beginning to write the image.
      - The image size is compared against the size of the flash, not the
        number of undamaged blocks.  Add a check to detect if the size of
        the undamaged blocks was sufficient to contain the image.

yaffs_userland_07_mkyaffs_printf.patch

   mkyaffs has an incorrect format specifier in printf().
      - Fix it.

yaffs_userland_08_mkyaffsimage_argc.patch

   mkyaffsimage incorrectly implements check of value of argc.
      - Fix it.

yaffs_userland_09_mkyaffsimage_error_handling.patch

   mkyaffsimage error handling done slightly incorrectly and inconsistently.
      - Fix it.

yaffs_userland_10_mkyaffsimage_buf_overflow.patch

   Possible buffer overflow in mkyaffsimage, if path of source filesystem
   tree is too long.
      - Change sprintf() to snprintf() to prevent overflow.

--------------030805000800070709080609
Content-Type: application/x-gzip;
 name="patches_02_tar.gz"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
 filename="patches_02_tar.gz"

H4sIAMeR8UEAA+08a3faSLL5Cr+i1rvJBSNAEi8/kpxxbCfhjoN9bGdn5uT66AjRgDZCYvWI
7ZuT/36rqiUhAX7l4cncVWWMUHd19aO669nM3AytqQgMVW8++VGgqm211+vgU2+12y18qvje
5WcMTzRV67Vbak/vqE9UTddV/Ql0ftiIMhAFoekDPBn73qXpjm7EE+7Ef4zxPDLMF/y/Nsfj
wIgC4Tu4EFhijO2raG740+0Go31tH6qmqt1u+yb+t/WenvC/3dF7T1Rd7bTaT0D9nhO9Cf7D
+d93R+JqB5j38Q6YRGHQmJZffDuU6/W6JN3wfHuSp1+r1dZ1+8svUNdVVdmGGj00HbAkvJ6L
kRhDEPqRFZbh78IJRBlKhhG1dCw1Inu0CwDNJtD+hf4BeGPwLl3hZ7EmEovQJr4XzbN4UK4v
EM3QnoldwqMvhOOYQQimZYkgyCLO1iPOvJE9ti0k47lZdGs9ujU13Yko15qb5RpsQjMK/Kbt
Wk40Es2hHQZN3KNhYwq4BLYrgnSESjoEJaVOFJrlWn4uN06llp/KHTOp5Wdy40SQPy42KwMu
PqK8th0Bgf2/AsCczx0bZxB6MMbSADzXuWaet9rbxPNWR495LnkNco8Yx8N/CSs8u4P/pXtu
gNJ9d0Dp3ltgBfOOPbCC/wiboHTTdFa2wSrmrRuhdON0slshbeOPxCfsIz6K+GJbuEHCaDyG
sefD0PGsj4DCmIj4cX1QzomqKLSdoDn7yG/2zJyIhvUjRNbafhaia201i7DtFoswfvBuxpWz
4JNnj8DjvWxMhTkSvuHYYegII/SMoT0xyhCvyqmYRA7O/uT4rP97QxZ70/pLudnhBZz9tnfS
0iuLsupuDmuyBmvCWPUMFm+hFTwuXcKcrcWcrcG01mJaMWZtqfe1nS/hzdbhzVbxrHV4lsTL
7MSkBYmgM5JLuSZJaZXl254tRAP2XLDdsNFooBybuGKkgBlCODXDv0nh1WlL4dXOcRubwKVv
h8LIsbxC5VjSH+GhKOWYGiTfcbzY+WD/FWh6c7up6iniZAVxbRWJOhQ7pSU+B4u3bPUsVz1b
rrZy1VKCoRAo5dmYo13L0V4mXcuRXqa8mBFJCkirWW5g7Rf8K//ZltP/D7jF/m8ZsVwzPG9o
u2Pva72AO+x/rd3qJPZ/q61jva71uq3C/n8MuFmpPoI+vVmVxlq0pbFY1RRdRbGKIjw2iOB5
cB00bc8Kncb05XI5eQvBUrkZzBbltXJtUePYbnTV/CT8AC0brv27PYbKUX/w/nfjn4enZ/3j
gbF/fHAIL+HXw9PB4VFSWtGVjqJWq0xPmmVwfPyqP3h9bOjdbB+zcNTEvzodrmQAbMLWsmOU
I7E8d2xPloYvq2IyXEcUWJ8hCWwiLS4fNpMzaxnxlFB6bvyjP9qBdGmVT6A1tgDdq1YT/0Nz
W9ve6bR31B7TILP88GoO/9jYJWWJasjyIjd8hTYo2AGY8O/IRvvs0rwmY4/rbHeC2lCAG82G
aEhj8ZCxXcQeXoeiwdzs6UoXaluxRRS5UpXKcduzyRytpw8dfeuCu43Nf5dEUSx/ICeNcF6f
UQ/gkgrL2gFNYcaRl5jlQQkraQTBDnSVdM2AiuceFn7eUmBbAU3Fvxb+tfGvg/rlCw3izz6c
jwC3yP82xX+MS9N3kb3BN4SA7pD/nZ6mLcv/lqYW8v8xICf/+bDhyfgxoj9DfSH1M4XsNnVI
ROBnj0REVq4liGsEm5u17VOZuXE99/xQuJ8a042MLN5Ie8RiEm+b6A9swokv6pbpWOhzhSiT
9E63TgJOY/GFA3GimQtzE43567+WI9rSFQ2XlB6tJR0auXaQaJPsumXCcbetHLaJld67vd+N
41f/fbh/foaSFIEqs8yD7MBuVk3xuFk/9WL91Gvi8NXWjqrutLfW6Kc66qfDq1D4runAOHIt
ClAEHEc43N8H7GRkhma5zp43zyBlM80FKnKckSFHishK+sLbzRuxf0s+m2zu+T75ckQWKmvb
+ejmEfFFCfVJJUSJFmc5oPmZeaVp27T9Na0r93/GjcR1HpEXadiu4SDbKugKGSHFRhSwUZ/5
Iox8F0ngmnxh6wCNGDV1Is3RCHe1pqIricuqlxPShhHh8kqO7+MYB+ZMnEWzSv7kod+eDrHF
J1RrtXJDvJNO7LXFwwyiGY+ztji35VyIZEEJmRhTwT62eKFNJa4/wwMpYDOgR/WWY/kzmLJ6
jyVbj5ctZ7GGI8ceLtl75AcvFS1Oay3b2EflvMYGlsHCleI7TebcIuLuElehb/6gdECW/GLx
sqUyGaDxyuEjv+NsF61iYRhyx9ChMIK5Y1uiwqdKbio+CC4dtYNz4/3g18Hxb4NU6HNgmqdO
r03ZHZqB1B1agg/sLpGG2NHR4NdSSVNzZWfH+1So5wp/e3uOZe3sQUjG+1t/0NJvYut6tf39
uERcaLqR46xT1ZIvqqKiHFD0LdrPSdT6j73Xr8924A8Rgul66BL4gAUN2IPB3uCgPnbMYArB
XFgUS+YUAOC0QjFrALdf6OwdOMGv5pAwhM8RYArtj1Ahx3sIzqc2eyQjDxcz9MB0HO+SyaAm
mWPDmT3xOWANaN3N4CMqCeFg96YlSKh6lI6IX0lfoJdAnkyDSDCZfW9+jRt1GkJlv0r6SIc9
R8yncIwdHuFhZCzgxuceDmx/GvnW1HYcquUI9ituzzbmoTtBrgs6sIseUFWEclL7sWp7Z7pk
cMPzWNf9YlKXWsPyGtHHl2lLnvzc93CGM1qEsS9wpbxxiAa72IVrLwLLdMEXI5uExDBCM8Ym
royaOFqO5l8zISyMcDf57MChHp0F5L/Ry5vBezgSAeVT3ghX+KhgT6Ihbnk4Qna4gYBEj+sN
DcyAyc0JI5jKORGV1zSws3hg8BrdxRHzJF1mbjbwQrGD6+pcyz0EMlSK7iY2OnpzcqTE5ftA
GplmbHnYvewH61NyTfxYnHrDoI1noBYx3hrGwk9fLqcdfA87gsmXa99oTNS+mzFRSyXHV9r/
t/h/HaPbRjf+23L/BHf4f3q3veT/ab1OWy/8v8eAnzL/r21p7LTws5e9ACDcaIZmJIuC2OUw
zv84OTQO+qf4/fj0D2Vt9du904Oj/uDX9bVnJ4f7/b2jcv1LLtt8jp3iEVstROlhhrFQRYOg
UjEMFKj81TDO+oZRrVZ315v5UFohFnI3ca58bz5HEYiqCa0g/zqcoiYoleslEhhA/qdwQ9m0
P9rlNGzQ0lfKOdWKC4hmNso578hzJ8J/j8pzl7rA8259xCoS82TbN4DsbJTVNkl+KfqpnEYx
93Ec2DcaISjZUJMI17LJXCqxKGK8D3JByQkc7L07NI4OB2/O30INtAsaokScm6MP+kU6zXOU
OShbSWGTrjOTWY9sEoe4WUSgyBsCChoIM7S8PgZQBzQpAMmR+YUF2ZQyrf8uJ05RJ4aCpXds
Pm4rmkoGnUrPtZdJHnRZQTIjSRLuQsqFTBGUSpLa4b8j+xMqcJnww2EBKo4M3cVkmHgjYbVI
261ye10dxP3tObbJNhHprXThJOmYZyahZHi2d9TfO8sz7edzAlqcTcdPTWP3iR3b92SZSPMt
vhRB8YCEvfn4MrD7uLumOpiinQnSg11XHwPvNGRCUo9saulGyDUB1yzqInQWwi0jTDrNV2hd
I0y6y9cwwbgjiINTP1j+36L/u2n+b2RSYIaslcj9CnvgLv3f1pfjvy0Niwr9/wjwcwdNNFWn
E1/jJ4UvORY2M22X71CY/gTNYmkUb+LLp6pUsenZdTxSLqORv7tSipouECFJVaKU2+HwAlRq
wHJ+lHyzZ5MXHF7jN28eWoyZluDBmYUj8gIyzbERCmpZUktKDLoTEibFEhGl0OVb4cyTsjj9
hRQp32UMozHgk3JelKnqKugs5OTbZhWeIQLiUeaqRO0oSYbyZCZm9G03jm7IYIoWh+/uXE5W
ZCV7XElzgB9kNx86FxfwHHqM85kudJRyi1ir8T2O0hz93XBc2XglL3WFoF6pW0+dK3bcZQN2
lPGVtPtQkD2A2muGFpYY/Y+7oRD/qkyMIoglzpvyXFqcT9RbnXvPpVRCyhXJel7peBvA83iV
GujlBiJgLS6rai86mh43/iwftBzklVWQl0qcuFQ6+lYVXrwAesrlIMQMs2tctxuTKFGOOd0y
VUhIcxuZCdX02tYFjfJqPN5dW729qJbJky4vSBctnfb9VuSLjJGlXML1Jq8yfd/n84CGYsIq
vpsX7MBTZk3+3HBLmle86//2Irvbq1jJC5PQ7lNTZrrlUbgmFGgDJquFthE56DCK2A51cMDZ
9HJ+OMmoS+LKDisaf/9CiXEyijbRKHLi4EYQBmgUW5YQFA5HXx7S0Rz/Kqn82QL5keEW/d9L
9b9co68OBNx1/wfV/nL+t9sq8r+PAj+3/qcoPIqyWvy8n5C/W1nBOmVV/57Kqrae2FN161s1
XzoBileSspKOu7wzzRINEam8QRubtFxi/yTlKJon4RQrVnVebhGIOg1puLQYN0xzDTpPNz8R
4g4noSrjkQLvDt8dnu6dHSrwjAdRJZ2hVtmBTrTtXPg+Km1UTe/OD+Ipj03biXzxHymxvy/c
Iv+3jFzWng7b16mAO+S/2mst+3+63iniv48Cf6m7LB029WudOy1+0gUfLqoyLJYIqCzBHeAH
DCPbGfHtRc9zOGgms0xUHsKGYRzsnR8aRmwXA4dixxXqCp6/gFaVDd74nV5BSq2kyyjgvrI9
U4hTdm5w+vOD5bmfhB9eJF2kjWEB1CYGMmSTKOk1hJRcQ/t4SHeUmA5rjvtLxVvO/3b+/LMY
NqZY5VCS9AGS4I7z3+p09aXz3261i/jPo8Bf6vy3VPJv8XP5Dg0dCHflvsu6uzFrb9Hg1na9
O+7Bwfp7cCyWusoWSiW64JO/tOXKAH2ggHuQTWy4Jyb9NK6cxfWikFIPfKUtU8ynji+NZQrj
o25Q4sJMwkh5asN/GeRVm76Ic9Kcst40Fci+wrAah1K6uVBK9ipW/vdpssuKXJvzpV7lb52s
aeR+rGRva8ksDf/iKXlhpMWr+4ruaHP4TobJ4nkn6bJzcxJAuHiXN78CmjZvjC26MVeTjwf9
/io3/rnv0c8hjVS+MqbMrim5C40o/aY82np2vEnw7qB/ilO3/UwgT+5Q2MQP/zod9rYc9vbq
sG8ditRrqHiwVuoctNsvp7h9KhXuAAdCASqsZhQ2qwfvj45IXyWId2DCs2dQkbN6STb5wnVK
vI/+xPWQCQ12YhqN5AJVR9tStG08D/jUWw+cVil2dRbOThJcXOjFp8GGMo4cx+CLiUlkLNWa
l4IuBP0XJQpRVcXuEaVZ0igRe0KSXRTQTUtc+k3BYX/wz72j3exYviQe2BdpAcSXGDmkG39P
tqu8fIn/7jZNVnZ6vFNotfgj2P3e9guzp6dLaUVC68E21InkH/W4MEKeBvI2lRwSWzVPA3b7
iIR2IZ/6BfMqWfm1B1OLb/nckNqHZ7wuCmjKxoaCzFPkXt2VZhmTruL3pI/V3Zal3j8wTo+P
z5NRptHLzKbnmOJXEuN1sxwvEJVYtsvCP1vj5+Fm+09T8/bfMBobdONq7HiXD/MD78r/YfGy
/YcuYGH/PQb8tey/hZp/4M+sv1XNp/cGX6O8Sa+5QId+6rCs/6VYd4T7EFOgrbbo/3tRa6sd
+WPHh2lNlH5I3ZrNpVavvxyxdlQ2GhukyRkHnccbcBAJZyljbnVWfDz9VMl+wHnSXZ51VbkF
uYj15lpVRsOklcpeX8mUu+JyUcCByFIQq520NwWVf5P0PzFGyU0jUe0y3Rq4K01zA70HIVIF
ROxlnudVWbtqlDSlzruZ4CJSenp6fLoDcRzWGwO1IYUTJ9Xy/d3DZCHc8+Pjo+PBm6QOd3Fo
u5GI32OjSn46xJLMykitmlhSP5mCKqCAAgoooIACCiiggAIKKKCAAgoooIACCiiggAIKKKCA
AgoooIACCiiggAIKKKCAAgoooIACUvg/U5A50QB4AAA=
--------------030805000800070709080609--