+++
subversion@balloonboard.org [2010-08-20 16:33 +0100]:
> Author: codehelp
> Date: 2010-08-20 16:33:53 +0100 (Fri, 20 Aug 2010)
> New Revision: 1199
>
> Modified:
> balloon/trunk/Makefile.tools
> Log:
> Add a version check for multistrap and fail if version is too old after trying to install it.
>
> Modified: balloon/trunk/Makefile.tools
> ===================================================================
> --- balloon/trunk/Makefile.tools 2010-08-18 16:43:48 UTC (rev 1198)
> +++ balloon/trunk/Makefile.tools 2010-08-20 15:33:53 UTC (rev 1199)
> @@ -44,6 +44,7 @@
> multistrap:
> #testing if $@ is installed - install it if the build stops here
> /usr/sbin/multistrap --version &> /dev/null || if [ -e /etc/debian_version ]; then sudo apt-get $(EMDEBAPTOPTIONS) install multistrap; fi
> + dpkg --compare-versions `dpkg-query -W -f '$${Version}' multistrap` '>=' "2.1.5~tcl+1" || exit 2
This patches assumes you are running on a debian machine (and thus
have dpkg available). The tools
stuff wraps debian-specific actions in a check for if [ -e
/etc/debian_version ]. SO at least in theory it would still do
something useful on a non-debian box. Perhaps we should give up with
the pretence that that is practical, but the two lines above at least
are inconsistent in this regard.
It also assumes you are inside tcl and have acess to a version I
suspect is not available anywhere else - that's not sesnible on
balloon-board.org. You can put that as a patch in balloon-base if you
like...
normally a version check from the program itself is sufficient - i.e.
multstrap --version, not using the package tools. More generic.
Not sure what problem you are actually fixing here, but I don;t think
this is an appropriate fix for the bb.org context.
Wookey
--
Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM
http://wookware.org/
(text/plain)