X-Git-Url: http://aleph1.co.uk/gitweb/?a=blobdiff_plain;f=web%2Fcore%2Fmodules%2Fuser%2Fsrc%2FUserData.php;h=8056f33ce13d103fadc5366281be9feb164a28db;hb=0bf8d09d2542548982e81a441b1f16e75873a04f;hp=735c3de4e61435ae89cdcd5c3c5e620692d68813;hpb=a2bd1bf0c2c1f1a17d188f4dc0726a45494cefae;p=yaffs-website

diff --git a/web/core/modules/user/src/UserData.php b/web/core/modules/user/src/UserData.php
index 735c3de4e..8056f33ce 100644
--- a/web/core/modules/user/src/UserData.php
+++ b/web/core/modules/user/src/UserData.php
@@ -40,7 +40,7 @@ class UserData implements UserDataInterface {
       $query->condition('name', $name);
     }
     $result = $query->execute();
-    // If $module, $uid, and $name was passed, return the value.
+    // If $module, $uid, and $name were passed, return the value.
     if (isset($name) && isset($uid)) {
       $result = $result->fetchAllAssoc('uid');
       if (isset($result[$uid])) {
@@ -48,40 +48,35 @@ class UserData implements UserDataInterface {
       }
       return NULL;
     }
-    // If $module and $uid was passed, return the name/value pairs.
-    elseif (isset($uid)) {
-      $return = [];
+    $return = [];
+    // If $module and $uid were passed, return data keyed by name.
+    if (isset($uid)) {
       foreach ($result as $record) {
         $return[$record->name] = ($record->serialized ? unserialize($record->value) : $record->value);
       }
       return $return;
     }
-    // If $module and $name was passed, return the uid/value pairs.
-    elseif (isset($name)) {
-      $return = [];
+    // If $module and $name were passed, return data keyed by uid.
+    if (isset($name)) {
       foreach ($result as $record) {
         $return[$record->uid] = ($record->serialized ? unserialize($record->value) : $record->value);
       }
       return $return;
     }
     // If only $module was passed, return data keyed by uid and name.
-    else {
-      $return = [];
-      foreach ($result as $record) {
-        $return[$record->uid][$record->name] = ($record->serialized ? unserialize($record->value) : $record->value);
-      }
-      return $return;
+    foreach ($result as $record) {
+      $return[$record->uid][$record->name] = ($record->serialized ? unserialize($record->value) : $record->value);
     }
+    return $return;
   }
 
   /**
    * {@inheritdoc}
    */
   public function set($module, $uid, $name, $value) {
-    $serialized = 0;
-    if (!is_scalar($value)) {
+    $serialized = (int) !is_scalar($value);
+    if ($serialized) {
       $value = serialize($value);
-      $serialized = 1;
     }
     $this->connection->merge('users_data')
       ->keys([